SRE-3830: fix @Library guard test check#12
Merged
Conversation
Fix syntax error in the guard script that caused it to fail. Add unit tests for the guard to prevent regressions. - checks/guard-jenkins-library-pin.sh: Replace \( with [(] in the library_regex variable. - tests/guard-jenkins-library-pin-test.sh: New file. Seven-case unit test for the guard script. - .github/workflows/checks.yml: Add unit test step for the guard script. Signed-off-by: John E. Malmberg <john.malmberg@hpe.com>
janekmi
requested changes
Jun 9, 2026
janekmi
left a comment
janekmi
left a comment
There was a problem hiding this comment.
There is no https://daosio.atlassian.net/browse/SRE-3850 ticket. Please assign a correct one.
janekmi
requested changes
Jun 9, 2026
JohnMalmberg
changed the title
Signed-off-by: John E. Malmberg <john.malmberg@hpe.com>
janekmi
requested changes
Jun 11, 2026
Signed-off-by: John E. Malmberg <john.malmberg@hpe.com>
janekmi
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix syntax error in the guard script that caused it to fail. Add unit tests for the guard to prevent regressions.
checks/guard-jenkins-library-pin.sh: Replace ( with [(] in the library_regex variable.
tests/guard-jenkins-library-pin-test.sh: New file. Seven-case unit test for the guard script.
.github/workflows/checks.yml: Add unit test step for the guard script.